Change prefix to pica #272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
there're some logic in staking module, I'll take care this part |
anhductn2001
approved these changes
Nov 23, 2023
|
@RustNinja i prefer rename all at once, including repo and data dir. I believe data dir, sure need to be migrated/mounted/linked by validators, but that is not an issue. easy to handle. once in lifetime even to rename all and unify. |
RustNinja
force-pushed
the
dang/change-prefix-pica
branch
from
3263d79
to
1304d85
Compare
|
Can we fix CI? |
RustNinja
reviewed
Nov 29, 2023
|
@blasrodri fixing.... also, recommend we hold on a minute w/this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.